Refactor middleware#325
Merged
Merged
Conversation
florimondmanca
force-pushed
the
refactor/middleware-package
branch
from
6b94d00 to
4545646
Compare
Contributor
|
Could we do those extras in this PR too under the cover of "refactor middlewares"? |
Contributor
Author
Uh, I guess I'm OK with that. I have another idea for refactoring the |
florimondmanca
force-pushed
the
refactor/middleware-package
branch
from
64e2b1f to
910af27
Compare
Contributor
|
Totally agree. You might have some minor conflicts over the PR I just merged. |
Contributor
Author
|
Already force-pushed a rebase. 👍 |
sethmlarson
reviewed
Sep 7, 2019
sethmlarson
approved these changes
Sep 7, 2019
sethmlarson
left a comment
sethmlarson
left a comment
Contributor
There was a problem hiding this comment.
If you fix the one comment below you're good to merge this. 👍
This was referenced Sep 7, 2019
Kludex
referenced
this pull request
in pydantic/httpx2
May 11, 2026
Bumps [flake8-bugbear](https://github.com/PyCQA/flake8-bugbear) from 21.3.2 to 21.4.3. - [Release notes](https://github.com/PyCQA/flake8-bugbear/releases) - [Commits](PyCQA/flake8-bugbear@21.3.2...21.4.3) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prompted by #305 (comment)
Moves the existing middleware in
middleware.pyinto their own module in amiddlewarepackage.Next up, a basic auth refactor including:
to_bytes()build_basic_auth_header()helper.